{"id":132,"date":"2026-10-31T11:37:00","date_gmt":"2026-10-31T11:37:00","guid":{"rendered":"https:\/\/www.akifsen.com.tr\/blog\/?p=132"},"modified":"2026-10-31T11:37:00","modified_gmt":"2026-10-31T11:37:00","slug":"code-review-what-to-look-for","status":"publish","type":"post","link":"https:\/\/www.akifsen.com.tr\/blog\/2026\/10\/31\/code-review-what-to-look-for\/","title":{"rendered":"Kod \u0130ncelemesinde Neye Bakmal\u0131?"},"content":{"rendered":"\n<p class=\"wp-block-paragraph\">Bir pull request a\u00e7\u0131l\u0131r. Birka\u00e7 dakika i\u00e7inde yorumlar gelir:<\/p>\n\n\n\n<p class=\"wp-block-paragraph\">&#8220;Bu de\u011fi\u015fkenin ad\u0131 daha a\u00e7\u0131klay\u0131c\u0131 olabilir.&#8221;<\/p>\n\n\n\n<p class=\"wp-block-paragraph\">&#8220;Burada bo\u015fluk fazla.&#8221;<\/p>\n\n\n\n<p class=\"wp-block-paragraph\">&#8220;Bunu stream ile yazsak daha okunakl\u0131 olur.&#8221;<\/p>\n\n\n\n<p class=\"wp-block-paragraph\">Pull request onaylan\u0131r.<\/p>\n\n\n\n<p class=\"wp-block-paragraph\">\u0130ki hafta sonra production&#8217;da, ayn\u0131 pull request&#8217;teki bir de\u011fi\u015fiklik y\u00fcz\u00fcnden bir m\u00fc\u015fterinin verisi ba\u015fka bir m\u00fc\u015fteriye g\u00f6r\u00fcn\u00fcr.<\/p>\n\n\n\n<p class=\"wp-block-paragraph\">Kimse fark etmemi\u015fti. \u00c7\u00fcnk\u00fc herkes de\u011fi\u015fken isimlerine bak\u0131yordu.<\/p>\n\n\n\n<h2 class=\"wp-block-heading\">Kolay g\u00f6r\u00fcnen \u015feyler dikkati \u00e7eker<\/h2>\n\n\n\n<p class=\"wp-block-paragraph\">\u0130nsanlar\u0131n code review&#8217;da y\u00fczeysel konulara odaklanmas\u0131n\u0131n bir sebebi var. Bir de\u011fi\u015fken ad\u0131n\u0131 ele\u015ftirmek kolayd\u0131r. Kodun yan etkilerini, hata durumlar\u0131n\u0131 ve sistemin di\u011fer par\u00e7alar\u0131yla etkile\u015fimini d\u00fc\u015f\u00fcnmek ise zaman ve \u00e7aba ister.<\/p>\n\n\n\n<p class=\"wp-block-paragraph\">Format ve stil konular\u0131 otomatik ara\u00e7lara b\u0131rak\u0131lmal\u0131. Linter, formatter ve statik analiz ara\u00e7lar\u0131 CI&#8217;da \u00e7al\u0131\u015f\u0131yorsa, insan dikkati daha \u00f6nemli konulara kal\u0131r.<\/p>\n\n\n\n<h2 class=\"wp-block-heading\">\u00d6nce do\u011fruluk<\/h2>\n\n\n\n<p class=\"wp-block-paragraph\">\u0130lk soru, de\u011fi\u015fikli\u011fin yapmas\u0131 gereken \u015feyi ger\u00e7ekten yap\u0131p yapmad\u0131\u011f\u0131.<\/p>\n\n\n\n<p class=\"wp-block-paragraph\">Pull request a\u00e7\u0131klamas\u0131 ne iddia ediyor? Kod bunu yap\u0131yor mu? S\u0131n\u0131r durumlar d\u00fc\u015f\u00fcn\u00fclm\u00fc\u015f m\u00fc? Bo\u015f liste, null de\u011fer, \u00e7ok b\u00fcy\u00fck girdi, e\u015fzamanl\u0131 \u00e7a\u011fr\u0131?<\/p>\n\n\n\n<p class=\"wp-block-paragraph\">Bunu anlamak i\u00e7in bazen kodu yerel ortamda \u00e7al\u0131\u015ft\u0131rmak gerekir. Sadece diff&#8217;i okumak her zaman yeterli de\u011fildir.<\/p>\n\n\n\n<h2 class=\"wp-block-heading\">Hata durumlar\u0131<\/h2>\n\n\n\n<p class=\"wp-block-paragraph\">Mutlu yol genellikle do\u011fru yaz\u0131lm\u0131\u015ft\u0131r. \u00c7\u00fcnk\u00fc geli\u015ftirici onu test etmi\u015ftir.<\/p>\n\n\n\n<p class=\"wp-block-paragraph\">As\u0131l risk hata durumlar\u0131ndad\u0131r. D\u0131\u015f servis cevap vermezse ne olur? Veritaban\u0131 yazmas\u0131 ba\u015far\u0131l\u0131, ard\u0131ndan gelen event g\u00f6nderimi ba\u015far\u0131s\u0131z olursa? Yar\u0131da kesilen bir i\u015flem tekrar \u00e7al\u0131\u015ft\u0131r\u0131l\u0131rsa?<\/p>\n\n\n\n<p class=\"wp-block-paragraph\">Bir exception yakalan\u0131p loglan\u0131yor ve ak\u0131\u015f devam ediyorsa, bu ger\u00e7ekten istenen davran\u0131\u015f m\u0131?<\/p>\n\n\n\n<h2 class=\"wp-block-heading\">Veri ve geri al\u0131nabilirlik<\/h2>\n\n\n\n<p class=\"wp-block-paragraph\">Kod de\u011fi\u015fiklikleri geri al\u0131nabilir. Veri de\u011fi\u015fiklikleri genellikle al\u0131namaz.<\/p>\n\n\n\n<p class=\"wp-block-paragraph\">Migration varsa, eski versiyonla uyumlu mu? B\u00fcy\u00fck bir tabloyu kilitleyecek mi? Geri alma plan\u0131 var m\u0131?<\/p>\n\n\n\n<p class=\"wp-block-paragraph\">Yeni bir alan ekleniyorsa, mevcut kay\u0131tlar i\u00e7in de\u011feri ne olacak?<\/p>\n\n\n\n<p class=\"wp-block-paragraph\">Bir API s\u00f6zle\u015fmesi de\u011fi\u015fiyorsa, mevcut client&#8217;lar k\u0131r\u0131lacak m\u0131?<\/p>\n\n\n\n<h2 class=\"wp-block-heading\">G\u00fcvenlik<\/h2>\n\n\n\n<p class=\"wp-block-paragraph\">Her yeni endpoint i\u00e7in: yetki kontrol\u00fc var m\u0131? Kullan\u0131c\u0131 sadece kendi verisine mi eri\u015fiyor?<\/p>\n\n\n\n<p class=\"wp-block-paragraph\">Kullan\u0131c\u0131dan gelen veri bir sorguya, bir dosya yoluna veya bir komuta do\u011frudan giriyor mu?<\/p>\n\n\n\n<p class=\"wp-block-paragraph\">Log&#8217;lara hassas veri yaz\u0131l\u0131yor mu?<\/p>\n\n\n\n<p class=\"wp-block-paragraph\">Bu kontroller bir checklist gibi g\u00f6r\u00fcnse de, en ciddi hatalar\u0131n bir k\u0131sm\u0131 bu sorulardan biri sorulmad\u0131\u011f\u0131 i\u00e7in production&#8217;a \u00e7\u0131k\u0131yor.<\/p>\n\n\n\n<h2 class=\"wp-block-heading\">Testler<\/h2>\n\n\n\n<p class=\"wp-block-paragraph\">Testler var m\u0131? Daha \u00f6nemlisi, testler ger\u00e7ekten de\u011fi\u015fikli\u011fin davran\u0131\u015f\u0131n\u0131 do\u011fruluyor mu?<\/p>\n\n\n\n<p class=\"wp-block-paragraph\">Bir bug d\u00fczeltmesinde, o bug&#8217;\u0131 yeniden \u00fcretecek bir test eklenmi\u015f olmal\u0131. Test kodu kald\u0131r\u0131ld\u0131\u011f\u0131nda k\u0131r\u0131lm\u0131yorsa, bir \u015feyi test etmiyordur.<\/p>\n\n\n\n<h2 class=\"wp-block-heading\">Tasar\u0131m en son de\u011fil ama erken<\/h2>\n\n\n\n<p class=\"wp-block-paragraph\">B\u00fcy\u00fck tasar\u0131m tart\u0131\u015fmalar\u0131 pull request a\u015famas\u0131nda yap\u0131l\u0131rsa, geli\u015ftirici g\u00fcnlerce \u00e7al\u0131\u015ft\u0131\u011f\u0131 bir i\u015fi ba\u015ftan yapmak zorunda kalabilir.<\/p>\n\n\n\n<p class=\"wp-block-paragraph\">\u00d6nemli tasar\u0131m kararlar\u0131, kod yaz\u0131lmadan \u00f6nce k\u0131sa bir tart\u0131\u015fma veya bir ADR tasla\u011f\u0131 ile konu\u015fulmal\u0131. Code review&#8217;da tasar\u0131ma dair yorumlar, karar\u0131n uygulan\u0131\u015f \u015fekline odaklanmal\u0131.<\/p>\n\n\n\n<h2 class=\"wp-block-heading\">K\u00fc\u00e7\u00fck pull request&#8217;ler<\/h2>\n\n\n\n<p class=\"wp-block-paragraph\">Bunlar\u0131n hepsi k\u00fc\u00e7\u00fck pull request&#8217;lerde m\u00fcmk\u00fcn. 2000 sat\u0131rl\u0131k bir de\u011fi\u015fikli\u011fi dikkatle incelemek ger\u00e7ek\u00e7i de\u011fil. \u0130nceleme y\u00fczeysel kal\u0131r ve &#8220;LGTM&#8221; ile biter.<\/p>\n\n\n\n<p class=\"wp-block-paragraph\">Code review, hatalar\u0131 yakalaman\u0131n yan\u0131nda bilgiyi ekip i\u00e7inde yayman\u0131n da bir yolu.<\/p>\n\n\n\n<p class=\"wp-block-paragraph\">Ama bu de\u011feri ancak do\u011fru sorular soruldu\u011funda \u00fcretiyor.<\/p>\n","protected":false},"excerpt":{"rendered":"<p>Code review&#8217;lar\u0131n \u00e7o\u011fu isimlendirme ve format tart\u0131\u015fmas\u0131nda kal\u0131yor. As\u0131l de\u011fer \u00fcreten sorular: davran\u0131\u015f do\u011fru mu, hata durumlar\u0131 ne olacak, geri al\u0131nabilir mi?<\/p>\n","protected":false},"author":1,"featured_media":131,"comment_status":"open","ping_status":"open","sticky":false,"template":"","format":"standard","meta":{"footnotes":""},"categories":[6],"tags":[],"class_list":["post-132","post","type-post","status-publish","format-standard","has-post-thumbnail","hentry","category-mimari"],"_links":{"self":[{"href":"https:\/\/www.akifsen.com.tr\/blog\/wp-json\/wp\/v2\/posts\/132","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/www.akifsen.com.tr\/blog\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/www.akifsen.com.tr\/blog\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/www.akifsen.com.tr\/blog\/wp-json\/wp\/v2\/users\/1"}],"replies":[{"embeddable":true,"href":"https:\/\/www.akifsen.com.tr\/blog\/wp-json\/wp\/v2\/comments?post=132"}],"version-history":[{"count":1,"href":"https:\/\/www.akifsen.com.tr\/blog\/wp-json\/wp\/v2\/posts\/132\/revisions"}],"predecessor-version":[{"id":206,"href":"https:\/\/www.akifsen.com.tr\/blog\/wp-json\/wp\/v2\/posts\/132\/revisions\/206"}],"wp:featuredmedia":[{"embeddable":true,"href":"https:\/\/www.akifsen.com.tr\/blog\/wp-json\/wp\/v2\/media\/131"}],"wp:attachment":[{"href":"https:\/\/www.akifsen.com.tr\/blog\/wp-json\/wp\/v2\/media?parent=132"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/www.akifsen.com.tr\/blog\/wp-json\/wp\/v2\/categories?post=132"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/www.akifsen.com.tr\/blog\/wp-json\/wp\/v2\/tags?post=132"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}